-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add html push analytics #598
Conversation
🚀 Deployed on https://pr-598--dhis2-scheduler.netlify.app |
1d6fad2
to
53de40f
Compare
53de40f
to
da122e4
Compare
471c996
to
4743b45
Compare
ff72b11
to
026f842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested this and it looks fine - the job itself fails, but I guess that has nothing to do with scheduler itself.
I assume not. The scheduler's responsibility basically ends with the POST of the (new or edited) job details to the backend. But it might be worth mentioning it to Jan Bernitt. |
Let me know what you think of my feedback @kabaros. If you're ok with it this PR is good to go imo. |
yeah it makes sense, I don't think it's in the scope of this PR to check the job itself - I am ok for the PR to be merged. |
# [101.5.0](v101.4.2...v101.5.0) (2024-03-06) ### Features * add html push analytics ([#598](#598)) ([f875dd1](f875dd1))
🎉 This PR is included in version 101.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
https://dhis2.atlassian.net/browse/DHIS2-16929
Todo
Follow up
input.value
of typestring
supplied toQueueTransfer
, expectedarray
, when there are no jobs for the queue