Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add html push analytics #598

Merged
6 commits merged into from
Mar 6, 2024
Merged

fix: add html push analytics #598

6 commits merged into from
Mar 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 27, 2024

https://dhis2.atlassian.net/browse/DHIS2-16929

Todo

  • Add custom components for html push analytics parameters:
    • dashboard, map of label to id from /api/dashboards, singleselect
    • receivers, map of label to id from /api/userGroups, singleselect
    • mode, set of labels, to be retrieved from the constants prop of the parameter, singleselect
  • Update tests

Follow up

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 27, 2024

🚀 Deployed on https://pr-598--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 27, 2024 15:38 Inactive
@ghost ghost changed the title fix: add html push analytics translation fix: add html push analytics Feb 27, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify February 27, 2024 17:04 Inactive
@ghost ghost force-pushed the add-push-analytics branch from 1d6fad2 to 53de40f Compare February 28, 2024 08:46
@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2024 08:59 Inactive
@ghost ghost force-pushed the add-push-analytics branch from 53de40f to da122e4 Compare February 28, 2024 10:22
@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2024 10:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2024 14:03 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 29, 2024 17:02 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 5, 2024 15:08 Inactive
@ghost ghost force-pushed the add-push-analytics branch from 471c996 to 4743b45 Compare March 5, 2024 15:12
@dhis2-bot dhis2-bot temporarily deployed to netlify March 5, 2024 15:15 Inactive
@ghost ghost force-pushed the add-push-analytics branch from ff72b11 to 026f842 Compare March 6, 2024 11:14
@dhis2-bot dhis2-bot temporarily deployed to netlify March 6, 2024 11:16 Inactive
@ghost ghost marked this pull request as ready for review March 6, 2024 11:27
@ghost ghost requested review from a team as code owners March 6, 2024 11:27
Copy link

@kabaros kabaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this and it looks fine - the job itself fails, but I guess that has nothing to do with scheduler itself.

@ghost
Copy link
Author

ghost commented Mar 6, 2024

tested this and it looks fine - the job itself fails, but I guess that has nothing to do with scheduler itself.

I assume not. The scheduler's responsibility basically ends with the POST of the (new or edited) job details to the backend. But it might be worth mentioning it to Jan Bernitt.

@ghost
Copy link
Author

ghost commented Mar 6, 2024

Let me know what you think of my feedback @kabaros. If you're ok with it this PR is good to go imo.

@kabaros
Copy link

kabaros commented Mar 6, 2024

Let me know what you think of my feedback @kabaros. If you're ok with it this PR is good to go imo.

yeah it makes sense, I don't think it's in the scope of this PR to check the job itself - I am ok for the PR to be merged.

@ghost ghost merged commit f875dd1 into master Mar 6, 2024
11 checks passed
@ghost ghost deleted the add-push-analytics branch March 6, 2024 15:49
dhis2-bot added a commit that referenced this pull request Mar 6, 2024
# [101.5.0](v101.4.2...v101.5.0) (2024-03-06)

### Features

* add html push analytics ([#598](#598)) ([f875dd1](f875dd1))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants