Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: swap relative and absolute time #596

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2024

https://dhis2.atlassian.net/browse/DHIS2-16407

Notes & follow up

  • We don't add the hover info when the output is "Now", could still be useful to add it
  • We could display the absolute time in the user's TZ instead of the server's TZ. Depends on what we think is clearer. Times being scheduled in the server's TZ does make me think the server's TZ would be clearer, if marked clearly as the server's TZ.
  • We should display a clear warning if the server's TZ is different from the user's TZ. We should make it obvious that tasks are planned according to the server's TZ and mention how big the time difference is, if there is one (maybe with a note above or below the table?)
  • Improve granularity for relative time
  • Instead of on hover, show an indicator that there is more info and show the info on click. Better for touch based devices.

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-596--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 15, 2024 14:54 Inactive
@ghost
Copy link
Author

ghost commented Feb 21, 2024

Closed for now. Updated parent issue with notes.

@ghost ghost closed this Feb 21, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant