fix: update label to indicate job is attempting to run now #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-592--dhis2-scheduler.netlify.app |
ghost
marked this pull request as ready for review
kabaros
approved these changes
Feb 5, 2024
Birkbjo
approved these changes
Feb 6, 2024
|
🎉 This PR is included in version 101.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/DHIS2-14787
https://dhis2.atlassian.net/browse/DHIS2-15764 (partially)
We used to show
Not scheduledunder theNext runcolumn for jobs that had theirnextExecutionTimein the past, like so:The intention was to indicate to users that the next run hadn't been planned yet, because the backend was working on executing it at that point, and would only schedule a new job after. That was confusing users a little, because we still showed
scheduledas the job status.So to indicate that the backend is currently working on trying to execute the job, this changes that to show
Nowinstead:Since we don't have a lot of space to tell the user the whole story, "Now" seems the most correct and easy to understand.