test: add queue row expansion test

dhis2 · Nov 16, 2023 · 7ad94fc · 7ad94fc
1 parent b666038
commit 7ad94fc
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 4 deletions.
diff --git a/cypress/integration/list/list-queues.feature b/cypress/integration/list/list-queues.feature
@@ -4,3 +4,5 @@ Feature: Queues should be listed
         Given a queue exists
         And the user navigated to the list page
         Then the queue is rendered as tabular data
+        And the user clicks the expand button
+        Then the queued jobs are shown
diff --git a/cypress/integration/list/list-queues/index.js b/cypress/integration/list/list-queues/index.js
@@ -12,3 +12,12 @@ Given('the user navigated to the list page', () => {
 Then('the queue is rendered as tabular data', () => {
     cy.findByRole('rowheader', { name: 'Queue' }).should('exist')
 })
+
+Given('the user clicks the expand button', () => {
+    cy.findByRole('button', { name: 'Show jobs' }).click()
+})
+
+Then('the queued jobs are shown', () => {
+    cy.findByRole('rowheader', { name: 'Job 1' }).should('exist')
+    cy.findByRole('rowheader', { name: 'Job 2' }).should('exist')
+})
diff --git a/i18n/en.pot b/i18n/en.pot
@@ -5,8 +5,8 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"POT-Creation-Date: 2023-11-08T08:39:40.580Z\n"
-"PO-Revision-Date: 2023-11-08T08:39:40.580Z\n"
+"POT-Creation-Date: 2023-11-16T13:48:39.789Z\n"
+"PO-Revision-Date: 2023-11-16T13:48:39.789Z\n"
 
 msgid "Something went wrong"
 msgstr "Something went wrong"
@@ -189,6 +189,12 @@ msgstr "No jobs to display"
 msgid "Not scheduled"
 msgstr "Not scheduled"
 
+msgid "Hide jobs"
+msgstr "Hide jobs"
+
+msgid "Show jobs"
+msgstr "Show jobs"
+
 msgid "Queue"
 msgstr "Queue"
 

diff --git a/src/components/JobTable/ExpandableRow.js b/src/components/JobTable/ExpandableRow.js
@@ -8,7 +8,9 @@ const ExpandableRow = ({ job }) => {
     return (
         <TableRow className={styles.row} suppressZebraStriping>
             <TableCell />
-            <TableCell className={styles.indent}>{job.name}</TableCell>
+            <TableCell role="rowheader" className={styles.indent}>
+                {job.name}
+            </TableCell>
             <TableCell className={styles.indent} colSpan="6">
                 {jobTypesMap[job.type]}
             </TableCell>

diff --git a/src/components/JobTable/QueueTableRow.js b/src/components/JobTable/QueueTableRow.js
@@ -35,7 +35,13 @@ const QueueTableRow = ({
         <>
             <TableRow>
                 <TableCell>
-                    <button className={styles.button} onClick={handleClick}>
+                    <button
+                        className={styles.button}
+                        onClick={handleClick}
+                        title={
+                            showJobs ? i18n.t('Hide jobs') : i18n.t('Show jobs')
+                        }
+                    >
                         {showJobs ? <IconChevronUp24 /> : <IconChevronDown24 />}
                     </button>
                 </TableCell>