feat: add class when map is rendered #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turban @jenniferarnesen I pushed commit 06fd528, which seems to have improved things a bit. My thinking behind this was that the timeout can be cleared when data is being fetched. It seems to have reduced the flickering of the download button in the maps-app a lot. But on slow 3G I do see it on initial app-load, but not when I have the app open and then navigate to a download view. Let me know if you'd like to keep it or revert it. |
HendrikThePendric
force-pushed
the
feat/map-rendered
branch
from
6587b1f to
06fd528
Compare
jenniferarnesen
approved these changes
Mar 4, 2024
HendrikThePendric
approved these changes
Mar 4, 2024
HendrikThePendric
added a commit
that referenced
this pull request
Mar 5, 2024
) * feat: add class when map is rendered * chore: code cleaning * chore: code cleaning * feat: check if bing layer is loaded * chore: code cleaning * fix: rendering timeout * chore: refactor * chore: change isLoading to within the trycatch * fix: clear render timeout when data is fetched or received * fix: restore check that returns if loading layers are encountered * Revert "feat: add class when map is rendered and push-analytics helper files and classes (#552)" This reverts commit c3830ac. * fix: adjust test to changes * chore: deduplicate node modules * chore: add verify-app workflow * fix: ensure mock Map class is an actual class * fix: include error message when rejecting a promise * fix: mock earth engine worker with class implementation * fix: mock `getWorkerInstance` method instead of `getEarthEngineWorker` function --------- Co-authored-by: Bjørn Sandvik <[email protected]> Co-authored-by: Jen Jones Arnesen <[email protected]>
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a "dhis2-map-rendered" to the map container when the map is fully rendered, and remove it if the map is rendering.
We will use it in DHIS2 Maps to control when the map is ready for download (used in push analytics).
Related PR: dhis2/maps-app#3072