Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report release job of release workflow needs output from the release job #3418

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Dec 2, 2024

Setting environment variables doesn't persist between jobs, so use output instead to record whether a build was successful.

Also fixed a test that started to fail when "This month" became December rather than November. Choosing fixed dates should fix this problem.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 2, 2024

🚀 Deployed on https://pr-3418.maps.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify December 2, 2024 13:18 Inactive
@jenniferarnesen jenniferarnesen added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Dec 3, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 08:59 Inactive
Copy link

cypress bot commented Dec 3, 2024

maps    Run #3366

Run Properties:  status check passed Passed #3366  •  git commit d7e8331712 ℹ️: Merge 045b5ac259299a918e3bfe0fc86f1c747804764e into 32b01ed1577c2d52cb75c644f1db...
Project maps
Branch Review chore/report-release-result-fix
Run status status check passed Passed #3366
Run duration 06m 09s
Commit git commit d7e8331712 ℹ️: Merge 045b5ac259299a918e3bfe0fc86f1c747804764e into 32b01ed1577c2d52cb75c644f1db...
Committer Jen Jones Arnesen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29
View all changes introduced in this branch ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 10:35 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 10:40 Inactive
@jenniferarnesen jenniferarnesen removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Dec 3, 2024
@jenniferarnesen jenniferarnesen merged commit 0dc3e8c into master Dec 5, 2024
28 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/report-release-result-fix branch December 5, 2024 09:09
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.7.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants