Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin crashes for Earth Engine layers in the dashboard #3302

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

turban
Copy link
Contributor

@turban turban commented Aug 14, 2024

Maps plugin is crashing in the dasboard for EE maps due to a missing filters prop. It also fixes issues with backward compatibility issues with older maps with EE layers.

With this fix EE layers load on Dashboard:

Screenshot 2024-08-14 at 14 04 51

Thematic layers added to the same map respects the dashboard filters:

Screenshot 2024-08-14 at 14 04 39

@turban turban requested a review from jenniferarnesen August 14, 2024 08:53
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Aug 14, 2024

🚀 Deployed on https://pr-3302--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify August 14, 2024 08:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 14, 2024 10:04 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 14, 2024 10:15 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 14, 2024 12:14 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 14, 2024 20:53 Inactive
@jenniferarnesen jenniferarnesen changed the title fix: ee layer filters defaults to empty array fix: plugin crashes for Earth Engine layers in the dashboard Aug 15, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify August 15, 2024 12:59 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 15, 2024 13:02 Inactive
@jenniferarnesen jenniferarnesen merged commit 8409f97 into master Aug 15, 2024
18 checks passed
@jenniferarnesen jenniferarnesen deleted the fix/ee-loader-filters branch August 15, 2024 13:28
dhis2-bot added a commit that referenced this pull request Aug 15, 2024
## [100.6.3](v100.6.2...v100.6.3) (2024-08-15)

### Bug Fixes

* plugin crashes for Earth Engine layers in the dashboard ([#3302](#3302)) ([8409f97](8409f97))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants