fix: avoid crash if layer title is undefined #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3286--dhis2-maps.netlify.app |
jenniferarnesen
approved these changes
Aug 8, 2024
|
🎉 This PR is included in version 100.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To set the
data-testattribute on theLayerCarddiv we use replace to remove whitespace from thetitle(introduced in #3021).In some edge cases
titlecan be undefined, and we avoid this error if we set the fallback value to''.This crash bug was reported for https://qa.im.dhis2.org/master/dhis-web-maps/#/AHWtSmx21sx
The error occurs for two saved maps with old EE layers that should be removed from from Sierra Leone demo database: