feat: add support for hash routing in line with other analytics apps [DHIS2-15762] #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[DHIS2-15762] (#3009) Implements https://dhis2.atlassian.net/browse/DHIS2-15762 Continue to support the old url patterns for backwards compatibility Supports: /#/ZBjCfSaLSqD /#/ZBjCfSaLSqD/download /#/ZBjCfSaLSqD?interpretationId=yKqhXZdeJ6a /#/ZBjCfSaLSqD?interpretationId=yKqhXZdeJ6a&initialFocus=true /#/currentAnalyticalObject /#/download (new map, in download mode) // legacy urls /?id=ZBjCfSaLSqD /?id=ZBjCfSaLSqD&interpretationid=yKqhXZdeJ6a /?id=ZBjCfSaLSqD&interpretationId=yKqhXZdeJ6a /?currentAnalyticalObject=true The app supports legacy urls (see above) because dashboard-app still produces the legacy url for both opening the map, and opening an interpretation. In addition, urls to maps may have been shared in other ways. In maps-app, legacy urls are replaced with the new url style when the maps-app first opens (AppWrapper) FileMenu: push paths to history for the various actions. Also, some renaming was done in the file to (hopefully) increase clarity. useLoadMap: this is where all the map loading and history listening is set up. Refactoring. Previously there were 3 components that dealt with initiating the maps app: AppWrapper, App, AppLayout. App has become the former "AppLayout", and all of the loading and navigating logic has been moved to the new custom hook useLoadMap
|
🚀 Deployed on https://pr-3107--dhis2-maps.netlify.app |
Passing run #2862 ↗︎
Details:
Review all test suite changes for PR #3107 ↗︎ |
|||||||||||||||
Passing run #2863 ↗︎
Details:
Review all test suite changes for PR #3107 ↗︎ |
|||||||||||||||
HendrikThePendric
approved these changes
Jan 12, 2024
janhenrikoverland
approved these changes
Jan 12, 2024
|
🎉 This PR is included in version 100.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://dhis2.atlassian.net/browse/DHIS2-15762