fix: load extended data whenever an event layer is shown in datatable #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3076--dhis2-maps.netlify.app |
1 failed test on run #2898 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data table > opens the data table for a Thematic layer |
Screenshots
Video
|
|
Review all test suite changes for PR #3076 ↗︎
|
Fixed for v40 in #3015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-16269
The reason this was happening was because the layer Id was not being checked before showing the new data table, so the effect to load extended was not triggered.
Instead of having data table trigger loading the extended data through an useEffect, load the extended data in the Event Loader, and have datatable wait until that data is loaded.
Main changes are in: