Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force table cell content to wrap to prevent overly wide modal #2961

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Sep 13, 2023

Fixes: https://dhis2.atlassian.net/browse/DHIS2-5920

  • Adding a max-width to the popup results in table cell content wrapping when needed.
  • Event popup styles migrated from maps-gl. Styles are still in maps-gl as well so as not to break 2.38 and 2.39.
  • Removed unused styles in popup.css

Before:
image

After:
image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 13, 2023

🚀 Deployed on https://pr-2961--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 13, 2023 08:33 Inactive
@cypress
Copy link

cypress bot commented Sep 13, 2023

1 flaky test on run #2530 ↗︎

0 36 20 0 Flakiness 1

Details:

Merge ddd8ea8 into 06e7481...
Project: maps Commit: b0c5aa8cd1 ℹ️
Status: Passed Duration: 04:34 💡
Started: Sep 14, 2023 8:30 AM Ended: Sep 14, 2023 8:35 AM
Flakiness  cypress/integration/dataDownload.cy.js • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data Download > downloads data from a thematic layer Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@turban turban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment:
Keep th header cells and maybe add scope="row"? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/th

Good for screen readers, but I'm not sure if they're able to access this popup anyway.

@dhis2-bot dhis2-bot temporarily deployed to netlify September 14, 2023 08:18 Inactive
@jenniferarnesen jenniferarnesen merged commit 87fe4cc into dev Sep 14, 2023
10 checks passed
@jenniferarnesen jenniferarnesen deleted the fix/event-popup-text-wrapping branch September 14, 2023 09:10
jenniferarnesen added a commit that referenced this pull request Sep 15, 2023
@jenniferarnesen jenniferarnesen restored the fix/event-popup-text-wrapping branch September 15, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants