feat: custom calculations for thematic layer (DHIS2-15474) #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(plugin): send installation status * fix: use window.parent * fix: bump cli-app-scripts for precaching improvement
Automatically merged.
* docs: move docs to app * chore: clean up old files * chore: gitignore * chore: gitignore
Automatically merged.
Automatically merged.
Automatically merged.
Automatically merged.
Automatically merged.
The "add event layer" test continues to be flaky. This change increases the timeout to 50 seconds. Also, since the default timeout is now 15 seconds, the EXTENDED_TIMOUT option isn't needed anymore (since that also sets to 15 seconds)
This is to test whether dependabot will automatically use the default branch.
* chore: increase cypress extended timeout * chore: use maps-app emoji in nightly slack message
|
🚀 Deployed on https://pr-2745--dhis2-maps.netlify.app |
Good idea. I suggest adding a help text under the Calculation input with content |
cooper-joe
approved these changes
Aug 31, 2023
1 flaky test on run #2496 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data Download > downloads data from a thematic layer |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
Help text added:
|
jenniferarnesen
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom calculations for thematic layers.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-15474
After this PR there is a new "Calculations" data type:
A new drop down allows you to select a custom calculation:
If there are no calculations an empty dropdown will show:
@cooper-joe, maybe we should add a help text telling that the user can create custom calculations in the Data Visualizer app? This is not intuitive.
Custom calculation layer added to the map:
Using this custom calculation:
