-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: move getPrecision to numbers file and rename fns (#3128)
Refactor work: * getPrecision will be used by geojson layers, so it has been moved from utils/earthEngine to utils/numbers * numberPrecision has been renamed to clearly reflect that a function is being returned * unit tests added for some functions in util/numbers * removed old files from the previous DataTable, as they are no longer in use * in classify remove exports that are not used outside of the file, and comment unused function
- Loading branch information
1 parent
3f9e667
commit e128cca
Showing
12 changed files
with
155 additions
and
180 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import { formatCount, getPrecision } from '../numbers.js' | ||
|
|
||
| describe('numbers', () => { | ||
| describe('formatCount', () => { | ||
| it('should return the original count for numbers less than 1000', () => { | ||
| expect(formatCount(500)).toEqual(500) | ||
| }) | ||
|
|
||
| it('should format numbers between 1000 and 9500 with one decimal place and a "k"', () => { | ||
| expect(formatCount(3300)).toEqual('3.3k') | ||
| }) | ||
|
|
||
| it('should round numbers between 9500 and 999500 to the nearest thousand and add a "k"', () => { | ||
| expect(formatCount(33000)).toEqual('33k') | ||
| }) | ||
|
|
||
| it('should format numbers between 999500 and 1950000 with one decimal place and a "M"', () => { | ||
| expect(formatCount(1300000)).toEqual('1.3M') | ||
| }) | ||
|
|
||
| it('should round numbers greater than 1950000 to the nearest million and add a "M"', () => { | ||
| expect(formatCount(33000000)).toEqual('33M') | ||
| }) | ||
| }) | ||
|
|
||
| describe('getPrecision', () => { | ||
| it('returns 0 for empty array', () => { | ||
| expect(getPrecision([])).toEqual(0) | ||
| }) | ||
|
|
||
| it('returns 0 with absValue >=10000', () => { | ||
| expect(getPrecision([10000, 10011, 10020, 10030])).toEqual(0) | ||
| }) | ||
|
|
||
| it('returns 0 with absValue >=1000 and gapValue > 10', () => { | ||
| expect(getPrecision([1010, 1000, 1050, 1030])).toEqual(0) | ||
| }) | ||
|
|
||
| it('returns 1 with absValue >=1000 and gapValue <= 10', () => { | ||
| expect(getPrecision([1000, 1001.135, 1002, 1003])).toEqual(1) | ||
| }) | ||
|
|
||
| it('returns 1 with absValue >=100 and gapValue > 1', () => { | ||
| expect(getPrecision([100, 106, 102, 103])).toEqual(1) | ||
| }) | ||
|
|
||
| it('returns 2 with absValue >=100 and gapValue <= 1', () => { | ||
| expect(getPrecision([100.67, 100.1, 100.2, 100.3])).toEqual(2) | ||
| }) | ||
|
|
||
| it('returns 2 with absValue >=10 and gapValue > 0.1', () => { | ||
| expect(getPrecision([20.99, 10.1, 10.2, 10.3])).toEqual(2) | ||
| }) | ||
|
|
||
| it('returns 3 with absValue >=10 and gapValue <= 0.1', () => { | ||
| expect(getPrecision([10.02, 10.01, 10.03, 10])).toEqual(3) | ||
| }) | ||
|
|
||
| it('returns 3 with absValue >=1 and gapValue > 0.01', () => { | ||
| expect(getPrecision([8, 8.07, 8.02, 8.03])).toEqual(3) | ||
| }) | ||
|
|
||
| it('returns 4 with absValue >=1 and gapValue <= 0.01', () => { | ||
| expect(getPrecision([1, 1.001, 1.002, 1.003])).toEqual(4) | ||
| }) | ||
|
|
||
| it('returns 4 with absValue <1 and gapValue > 0.001', () => { | ||
| expect(getPrecision([0.888, 0.101, 0.102, 0.103])).toEqual(4) | ||
| }) | ||
|
|
||
| it('returns 5 with absValue <1 and gapValue <= 0.001', () => { | ||
| expect(getPrecision([0.1, 0.1001, 0.1002, 0.1003])).toEqual(5) | ||
| }) | ||
|
|
||
| it('returns 1 with negative max and absValue >=100 and gapValue > 1', () => { | ||
| expect(getPrecision([100, -106, 102, 103])).toEqual(1) | ||
| }) | ||
|
|
||
| it('returns 2 with negative max and absValue >=100 and gapValue <= 1', () => { | ||
| expect(getPrecision([-100.67, -100.1, -100.2, -100.3])).toEqual(2) | ||
| }) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.