fix: indent org unit with no child and refresh lists on updates #473
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flaminic
force-pushed
the
small-org-unit-fixes
branch
from
c2dd1e1 to
3d68912
Compare
| @@ -53,6 +55,9 @@ export const useOnSubmitEdit = <TFormValues extends IdentifiableObject>({ | |||
| message: i18n.t('Saved successfully'), | |||
| success: true, | |||
| }) | |||
| queryClient.invalidateQueries({ | |||
There was a problem hiding this comment.
I think this makes a lot of sense, however I'm not sure if we want to couple the sectionPath to the resource?
getSectionPath is for the router, and if we in the future would want to change those paths.
I think it's more correct to use section.namePlural if we want to do this.
Initially I was thinking to add refetchOnMount: true on the queries for the list. That should fix the problem in this case. But I do agree that invalidating the query makes a lot of sense as well.
There was a problem hiding this comment.
Sounds good, i'll chande it to namePlural and keep it as it is then (i do like being explicit about it)
| @@ -87,7 +87,9 @@ export const OrganisationUnitRow = ({ | |||
| onClick={row.getToggleExpandedHandler()} | |||
| ></Button> | |||
| </> | |||
| ) : null} | |||
| ) : ( | |||
There was a problem hiding this comment.
Did we not decide to remove the expand all as well?
There was a problem hiding this comment.
yes i can do that as well
No description provided.