Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement description field validation #449

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

Chisomchima
Copy link
Member

Description

This PR implements description field validation by using the composeAsyncValidators function. this helps prevent users from inputing strings more than required.


Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 231645c
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/674884477bf2b4000909ddc4
😎 Deploy Preview https://deploy-preview-449--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Chisomchima Chisomchima changed the title Dhis2 18142/category option group forms feat: implement description field validation Nov 25, 2024
@Chisomchima Chisomchima requested a review from Birkbjo November 26, 2024 14:09
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need useValidator. I think we only need to check for max length.

src/components/form/fields/DescriptionField.tsx Outdated Show resolved Hide resolved
src/components/form/fields/DescriptionField.tsx Outdated Show resolved Hide resolved
@Chisomchima Chisomchima requested a review from Birkbjo November 28, 2024 14:58
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Chisomchima Chisomchima merged commit e3329ff into master Nov 28, 2024
10 checks passed
@Chisomchima Chisomchima deleted the DHIS2-18142/category-option-group-forms branch November 28, 2024 15:08
dhis2-bot added a commit that referenced this pull request Nov 28, 2024
# [0.18.0](v0.17.0...v0.18.0) (2024-11-28)

### Features

* implement description field validation ([#449](#449)) ([e3329ff](e3329ff))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants