fix: stop row loaders if there is an error #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
reviewed
Nov 14, 2024
| const isFiltering = !!identifiableFilter | ||
| const hasErrored = queries.find((query) => query.error) !== undefined |
There was a problem hiding this comment.
Very minor, almost don't want to comment on this - but this would be a bit more Idiomatic.
Suggested change
| const hasErrored = queries.find((query) => query.error) !== undefined | |
| const hasErrored = queries.some((query) => query.isError) |
flaminic
force-pushed
the
DHIS2-17848/stop-loading-on-error
branch
from
732c38e to
ec3d921
Compare
dhis2-bot
added a commit
that referenced
this pull request
Nov 14, 2024
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.