Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optionSetSelect): fix optionSet crashing with initialValue #439

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Nov 14, 2024

Background

When going to edit a dataElement with an optionSet selected, an error would be thrown due to the UseInitialOptionSet using the singular name of optionSet on the data from useOptionSetQuery.

@Birkbjo Birkbjo requested a review from Mohammer5 November 14, 2024 12:52
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 48571f1
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/673600864fe2990008bb5ac3
😎 Deploy Preview https://deploy-preview-439--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Birkbjo Birkbjo force-pushed the fix/optionset-crash branch 2 times, most recently from 5636464 to 48571f1 Compare November 14, 2024 13:52
@Birkbjo Birkbjo merged commit 93b8d68 into master Nov 14, 2024
16 checks passed
@Birkbjo Birkbjo deleted the fix/optionset-crash branch November 14, 2024 14:35
dhis2-bot added a commit that referenced this pull request Nov 14, 2024
## [0.13.1](v0.13.0...v0.13.1) (2024-11-14)

### Bug Fixes

* stop row loaders if there is an error ([#440](#440)) ([44a8080](44a8080))
* **optionSetSelect:** fix optionSet crashing with initialValue ([#439](#439)) ([93b8d68](93b8d68))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants