Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address feedback on org unit edit page #437

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: address feedback on org unit edit page #437

merged 1 commit into from
Nov 14, 2024

Conversation

flaminic
Copy link
Contributor

@flaminic flaminic commented Nov 13, 2024 •
edited
Loading

  • fix gap between address fields
  • change copies - attribute section title and subtitle + image upload help text
  • fix attributes validation on edit - we need to format the values according to the form formatter before the validation

@flaminic flaminic requested review from Birkbjo and a team November 13, 2024 08:34
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 3eb09fe
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/6735c4ae29ed33000872a1e0
😎 Deploy Preview https://deploy-preview-437--dhis2-maintenance-app-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flaminic flaminic force-pushed the DHIS2-17899/minor-fixes branch from 8dc0b27 to 9bd87df Compare November 14, 2024 08:56
Mohammer5
Mohammer5 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing me the changes, code LGTM.
Maybe wait for @Birkbjo to give input, too?

@flaminic flaminic force-pushed the DHIS2-17899/minor-fixes branch from 9bd87df to 4b8a7b0 Compare November 14, 2024 09:35
@flaminic
fix: address feedback on org unit edit page
3eb09fe 
- fix gap between come fields
- change copies
- fix attribues validation on edit
@flaminic flaminic force-pushed the DHIS2-17899/minor-fixes branch from 4b8a7b0 to 3eb09fe Compare November 14, 2024 09:36
@flaminic
Copy link
Contributor Author

Merging as @Birkbjo gave me feedback on slack

@flaminic flaminic merged commit 2341bcb into master Nov 14, 2024
10 checks passed
@flaminic flaminic deleted the DHIS2-17899/minor-fixes branch November 14, 2024 09:44
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohammer5 Mohammer5 Mohammer5 approved these changes

@Birkbjo Birkbjo Awaiting requested review from Birkbjo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaminic @dhis2-bot @Mohammer5