feat(list): context menu #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
commented
Feb 20, 2024
| } | ||
|
|
||
| /* Wrapping button with anchor-tags are not valid, style anchor as a UI-button */ | ||
| export const LinkButton = ({ |
There was a problem hiding this comment.
This should be done in UI, eg passing an as={'a'} or something similar to button component...
Mohammer5
approved these changes
Mar 5, 2024
Birkbjo
force-pushed
the
feat/list-context-menu
branch
from
77460bd to
c19814f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 73.30% 72.95% -0.36%
==========================================
Files 141 143 +2
Lines 1967 2000 +33
Branches 405 411 +6
==========================================
+ Hits 1442 1459 +17
- Misses 523 539 +16
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/DHIS2-15561?filter=10364