feat(filters): dynamic filter components - part 2

[Birkbjo]

No description provided.

[netlify]

✅ Deploy Preview for dhis2-maintenance-app-beta ready!

Name	Link
🔨 Latest commit	13baa3e
🔍 Latest deploy log	https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/65e21ef1fa10680008091983
😎 Deploy Preview	https://deploy-preview-367--dhis2-maintenance-app-beta.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 111 lines in your changes are missing coverage. Please review.

Project coverage is 73.30%. Comparing base (2c13a66) to head (13baa3e).

Files	Patch %	Lines
...components/sectionList/listView/ManageListView.tsx	5.88%	48 Missing ⚠️
...ectionList/filters/filterSelectors/ModelFilter.tsx	74.41%	11 Missing ⚠️
...mponents/sectionList/listView/useModelListView.tsx	35.29%	11 Missing ⚠️
...ist/filters/filterSelectors/PublicAccessFilter.tsx	18.18%	9 Missing ⚠️
src/lib/query/useInfiniteDataQuery.ts	66.66%	9 Missing ⚠️
...b/sectionList/filters/parseFiltersToQueryParams.ts	20.00%	8 Missing ⚠️
src/lib/models/parsePublicAccess.ts	33.33%	6 Missing ⚠️
...c/components/sectionList/filters/useFilterKeys.tsx	83.33%	2 Missing ⚠️
.../components/sectionList/filters/DynamicFilters.tsx	88.88%	1 Missing ⚠️
...st/filters/filterSelectors/CategoryComboFilter.tsx	83.33%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   74.15%   73.30%   -0.85%     
==========================================
  Files         133      141       +8     
  Lines        1811     1967     +156     
  Branches      348      405      +57     
==========================================
+ Hits         1343     1442      +99     
- Misses        466      523      +57     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Mohammer5]

I just gave it a try. I added the "public access" filter and removed the "domain type" filter. But the domain type filter is still showing.

[Birkbjo]

I just gave it a try. I added the "public access" filter and removed the "domain type" filter. But the domain type filter is still showing.

I just did this on the preview deployment and it works. Will update and fix conflicts in this branch though.

Did you select a domain type value? If a filter has a value, it will always show.

[Mohammer5]

Yeah, now it works for me as well. Not sure what happened, maybe I did select a value.
I suppose we could disable selected options in the transfer that have a value, but that's a question for @cooper-joe. For now it's fine I guess

[dhis2-bot]

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

• AppHub release
• GitHub release

Your semantic-release bot 📦🚀