Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(summarycard): adjust icon-less design #365

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix(summarycard): adjust icon-less design #365

merged 2 commits into from
Dec 21, 2023

Conversation

cooper-joe
Copy link
Member

This PR adjusts the summary card component design:

  • removes Card usage (may be deprecated from UI, so will not start using here)
  • removes icons (not adding value, can revisit if we want to spend time making many unique icons, but is a tough task.)
  • makes clickable area boundaries and interactions clearer
  • adjusts styling

Before:
image

After:
image

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for dhis2-maintenance-app-beta ready!

Name Link
🔨 Latest commit 72289c7
🔍 Latest deploy log https://app.netlify.com/sites/dhis2-maintenance-app-beta/deploys/65673d2949440f0008cd0425
😎 Deploy Preview https://deploy-preview-365--dhis2-maintenance-app-beta.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cooper-joe cooper-joe requested a review from Birkbjo November 29, 2023 13:31
Birkbjo
Birkbjo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cooper-joe cooper-joe merged commit 0fecea2 into master Dec 21, 2023
9 checks passed
@cooper-joe cooper-joe deleted the overview-card-styling branch December 21, 2023 12:34
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Birkbjo Birkbjo Birkbjo approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cooper-joe @dhis2-bot @Birkbjo