refactor(de and de groups): remove superfluous code

src/pages/dataElementGroups/Edit.tsx

@@ -6,7 +6,6 @@ import { withTypes } from 'react-final-form'
 import { useNavigate, useParams } from 'react-router-dom'
 import { Loader } from '../../components'
 import {
-    CustomAttributes,
     DefaultFormContents,
     useCustomAttributesQuery,
 } from '../../components/form'

src/pages/dataElementGroups/New.tsx

@@ -49,20 +49,8 @@ export function Component() {
     const dataEngine = useDataEngine()
     const navigate = useNavigate()
     const customAttributesQuery = useCustomAttributesQuery()
-    const loading = customAttributesQuery.loading
-    const error = customAttributesQuery.error
     const initialValues = useInitialValues(customAttributesQuery.data)
 
-    if (error && !loading) {
-        // @TODO(Edit): Implement error screen
-        return <>Error: {error.toString()}</>
-    }
-
-    if (loading) {
-        // @TODO(Edit): Implement loading screen
-        return <>Loading...</>
-    }
-
     async function onSubmit(payload: FormValues) {
         try {
             // We want the promise so we know when submitting is done. The promise

src/pages/dataElements/Edit.tsx

@@ -12,10 +12,10 @@ import {
 } from '../../components'
 import { useCustomAttributesQuery } from '../../components/form'
 import { SCHEMA_SECTIONS, getSectionPath, validate } from '../../lib'
+import { createJsonPatchOperations } from '../../lib/form/createJsonPatchOperations'
 import { getAllAttributeValues } from '../../lib/models/attributes'
 import { JsonPatchOperation } from '../../types'
 import { Attribute, DataElement } from '../../types/generated'
-import { createJsonPatchOperations } from './edit/'
 import classes from './Edit.module.css'
 import { DataElementFormFields, dataElementSchema } from './form'
 import type { FormValues } from './form'

src/pages/dataElements/New.tsx

@@ -106,20 +106,8 @@ export const Component = () => {
     const dataEngine = useDataEngine()
     const navigate = useNavigate()
     const customAttributesQuery = useCustomAttributesQuery()
-    const loading = customAttributesQuery.loading
-    const error = customAttributesQuery.error
     const initialValues = useInitialValues(customAttributesQuery.data)
 
-    if (error && !loading) {
-        // @TODO(Edit): Implement error screen
-        return <>Error: {error.toString()}</>
-    }
-
-    if (loading) {
-        // @TODO(Edit): Implement loading screen
-        return <>Loading...</>
-    }
-
     async function onSubmit(values: FormValues) {
         const payload = formatFormValues({ values })