fix: type checks

dhis2 · Dec 9, 2024 · bdd76bf · bdd76bf
1 parent 8ce5e1f
commit bdd76bf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/components/sectionList/modelValue/ModelValueRenderer.tsx b/src/components/sectionList/modelValue/ModelValueRenderer.tsx
@@ -18,6 +18,12 @@ export const ModelValueRenderer = ({
     value,
     schemaProperty,
 }: ValueDetails) => {
+    const hasToStringMethod = (
+        value: unknown
+    ): value is { toString: () => string } =>
+        typeof value === 'object' &&
+        typeof (value as any).toString === 'function'
+
     if (path === 'sharing.public' && typeof value === 'string') {
         return <PublicAccessValue value={value} />
     }
@@ -41,8 +47,9 @@ export const ModelValueRenderer = ({
         return <BooleanValue value={value} />
     }
 
-    if (value ?? false) {
+    if (value !== null && value !== undefined && hasToStringMethod(value)) {
         return <TextValue value={value.toString()} />
     }
+
     return null
 }
diff --git a/src/types/schemaBase.ts b/src/types/schemaBase.ts
@@ -35,6 +35,8 @@ export interface SchemaFieldProperty {
     unique: boolean
     required: boolean
     length?: number
+    max?: number
+    min?: number
     persisted: boolean
     collectionName?: string
     collection: boolean