feat: handle empty validation on handlechange

dhis2 · Nov 27, 2024 · ae41a24 · ae41a24
1 parent da6a8ff
commit ae41a24
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/components/form/fields/DateField.tsx b/src/components/form/fields/DateField.tsx
@@ -33,24 +33,22 @@ export function DateField({
 
     const { input, meta } = useField<string | undefined>(name)
 
-    useEffect(() => {
-        if (input.value === '' && meta.touched && required) {
+    const handleChange: CalendarInputProps['onDateSelect'] = (
+        payload: {
+            calendarDateString: string
+            validation?: ValidationProps
+        } | null
+    ) => {
+        if (!payload?.calendarDateString && required) {
             setValidation({
                 error: true,
                 valid: false,
                 validationCode: 'EMPTY',
                 validationText: i18n.t('Required'),
             })
+        } else {
+            setValidation(payload?.validation || { error: false })
         }
-    }, [required, input.value, meta.touched])
-
-    const handleChange: CalendarInputProps['onDateSelect'] = (
-        payload: {
-            calendarDateString: string
-            validation?: ValidationProps
-        } | null
-    ) => {
-        setValidation(payload?.validation || { error: false })
         input.onChange(payload?.calendarDateString || '')
         input.onBlur()
     }