fix(manageView): stable initialValues for form

dhis2 · Oct 18, 2024 · 928f367 · 928f367
1 parent 2c7c9a9
commit 928f367
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/src/components/sectionList/listView/ManageListView.tsx b/src/components/sectionList/listView/ManageListView.tsx
@@ -61,11 +61,20 @@ export const ManageListView = ({
     const section = useModelSectionHandleOrThrow()
     const { saveView } = useMutateModelListViews()
 
-    const columnsConfig = getColumnsForSection(section.name)
-    const filtersConfig = getFiltersForSection(section.name)
+    const { defaultColumns, defaultFilters, columnsConfig, filtersConfig } =
+        useMemo(() => {
+            const columnsConfig = getColumnsForSection(section.name)
+            const filtersConfig = getFiltersForSection(section.name)
 
-    const defaultColumns = columnsConfig.default.map(toPath)
-    const defaultFilters = filtersConfig.default.map(toFilterKey)
+            const defaultColumns = columnsConfig.default.map(toPath)
+            const defaultFilters = filtersConfig.default.map(toFilterKey)
+            return {
+                defaultColumns,
+                defaultFilters,
+                columnsConfig,
+                filtersConfig,
+            }
+        }, [section.name])
 
     const handleSave = async (values: FormValues) => {
         const isDefault = (arr: string[], def: string[]) =>