refactor: simplify parseFilters

dhis2 · Jan 25, 2024 · 36f21a9 · 36f21a9
1 parent 407c912
commit 36f21a9
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/lib/sectionList/filters/parseFiltersToQueryParams.ts b/src/lib/sectionList/filters/parseFiltersToQueryParams.ts
@@ -14,9 +14,9 @@ const getQueryParamForFilter = (
     key: FilterKey,
     value: AllValues,
     section?: Section
-): string => {
+): string | undefined => {
     if (!value) {
-        return ''
+        return undefined
     }
     if (key === 'identifiable') {
         return `identifiable:token:${value}`
@@ -34,13 +34,13 @@ export const parseFiltersToQueryParams = (
     filters: ParsedFilterParams,
     section?: Section
 ): string[] => {
-    const queryFilters: string[] = []
-    for (const [key, value] of Object.entries(filters)) {
-        if (!value) {
-            continue
-        }
-        const filter = getQueryParamForFilter(key as FilterKey, value, section)
-        queryFilters.push(filter)
-    }
+    const queryFilters = Object.entries(filters)
+        .map(([key, value]) =>
+            getQueryParamForFilter(key as FilterKey, value, section)
+        )
+        .filter(
+            (queryFilter): queryFilter is string => queryFilter !== undefined
+        )
+
     return queryFilters
 }