fix: prevent period SC to trigger on change when selected item is cli…

…cked
dhis2 · Mar 12, 2024 · a84d44e · a84d44e
1 parent bd00f95
commit a84d44e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cypress/helpers/period.js b/cypress/helpers/period.js
@@ -71,6 +71,8 @@ const selectRelativePeriod = ({ label, period }) => {
 
 const unselectAllPeriods = ({ label }) => {
     openPeriod(label)
+    cy.contains('Choose from presets').click()
+
     cy.getBySel('period-dimension-transfer-actions-removeall').click()
     cy.getBySel('period-dimension-modal-action-confirm').click()
 }

diff --git a/src/components/Dialogs/PeriodDimension/PeriodDimension.js b/src/components/Dialogs/PeriodDimension/PeriodDimension.js
@@ -165,8 +165,10 @@ export const PeriodDimension = ({ dimension, onClose }) => {
     }
 
     const onSegmentedControlChange = ({ value }) => {
-        setEntryMethod(value)
-        updatePeriodDimensionItems([])
+        if (value !== entryMethod) {
+            setEntryMethod(value)
+            updatePeriodDimensionItems([])
+        }
     }
 
     return dimension ? (