Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dry run instead of import mode when making api call to old tracker api #2033

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

flaminic
Copy link

@flaminic flaminic commented May 20, 2024

Partial fix for DHIS2-14864
Description

Partial fix for dry run mode on import of TEI, changed the parameter in the requests as per the documentation . The API Backend needs to be fixed as well for the bug to be resolved

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 20, 2024

🚀 Deployed on https://pr-2033--dhis2-import-export.netlify.app

@flaminic flaminic changed the title Use dryRun unstead of importMode when making api call to old tracker API Use dryRun instead of importMode when making api call to old tracker API May 20, 2024
@flaminic flaminic changed the title Use dryRun instead of importMode when making api call to old tracker API fix: use dry run instead of import mode when making api call to old tracker api May 20, 2024
@flaminic flaminic force-pushed the DHIS2-14864/v38-fix-dryrun-params branch from da06975 to 63379eb Compare May 20, 2024 13:03
@flaminic flaminic requested a review from a team May 30, 2024 12:23
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but the ticket says the backend change is only going to be backported down to 2.39? In which case, this change here won't contribute to fixing the problem in the app, so I guess it's not worth merging?

@flaminic flaminic merged commit 6db461d into v38 Jun 3, 2024
8 checks passed
@flaminic flaminic deleted the DHIS2-14864/v38-fix-dryrun-params branch June 3, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants