-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move app to continuous release #1978
Conversation
5b37f2f
to
e5d0889
Compare
🚀 Deployed on https://pr-1978--dhis2-import-export.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know too much about these configuration files, changes look good to me though.
Just a single question, approving though. If you want to get a more qualified review, you could ask someone else who knows more about the release processes.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "import-export-app", | |||
"version": "1.5.69", | |||
"version": "99.9.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is so that the first release will be 100.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah exactly - for context, here is a writeup of the steps needed to move to continuous release: dhis2/notes#293
type: 'app', | ||
name: 'import-export', | ||
title: 'Import/Export', | ||
description: 'Core app for importing and exporting data to and from DHIS2.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better descriptions welcome (but we can update this later)
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "import-export-app", | |||
"version": "1.5.69", | |||
"version": "99.9.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah exactly - for context, here is a writeup of the steps needed to move to continuous release: dhis2/notes#293
moving import/export app to continous release from v41. I didn't apply to earlier versions since it seems that a lot has changed between versions (geo import, and other stuff) so it's hard to tell what applies to all versions or not.