fix: avoid breaking selects [DHIS2-16264] #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1963--dhis2-import-export.netlify.app |
In that case we should add another Jira issue so we don't forget about it |
Mohammer5
approved these changes
Dec 15, 2023
KaiVandivier
force-pushed
the
DHIS2-16264-fix-selects
branch
from
252586f to
b2f0e02
Compare
KaiVandivier
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Dec 15, 2023
## [1.5.66](v1.5.65...v1.5.66) (2023-12-15) ### Bug Fixes * avoid breaking selects [DHIS2-16264] ([#1963](#1963)) ([4300ef2](4300ef2))
|
🎉 This PR is included in version 1.5.66 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
KaiVandivier
added a commit
that referenced
this pull request
Dec 15, 2023
* fix: loading logic * fix: hide stateful selects to preserve state * chore: format * chore: update snapshots
KaiVandivier
added a commit
that referenced
this pull request
Dec 15, 2023
* fix: loading logic * fix: hide stateful selects to preserve state * chore: format * chore: update snapshots
KaiVandivier
added a commit
that referenced
this pull request
Dec 15, 2023
* fix: loading logic * fix: hide stateful selects to preserve state * chore: format * chore: update snapshots
KaiVandivier
added a commit
that referenced
this pull request
Dec 15, 2023
* fix: loading logic * fix: hide stateful selects to preserve state * chore: format * chore: update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/DHIS2-16264
The select components do a fetch on render for attributes to populate some options (the top two or three are hard-coded though). If you select an option that was populated by the fetch, that value is saved in the Final Form state. If you collapse the Advanced Options section, then re-expand the section, the select tries to choose the option based on that value, but the component needs to fetch again, so that option isn't available on first render
Edited:
I changed the
<MoreOptions>component to keep children rendered to preserve state, and then hide them with CSSBefore:
before.mov
After:
after.mov