-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component #94
Merged
DavidAparicioAlbaAsenjo
merged 16 commits into
main
from
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
Oct 19, 2023
Merged
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component #94
DavidAparicioAlbaAsenjo
merged 16 commits into
main
from
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 6, 2023 10:39
c4214cf
to
a93e220
Compare
xavimolloy
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a test for the component?
...em/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/component/InputFileResource.kt
Outdated
Show resolved
Hide resolved
andresmr
approved these changes
Oct 9, 2023
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 10, 2023 13:00
3b477be
to
f29c39b
Compare
andresmr
approved these changes
Oct 11, 2023
xavimolloy
approved these changes
Oct 11, 2023
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 13, 2023 12:57
88262e2
to
d3766bf
Compare
andresmr
approved these changes
Oct 13, 2023
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
2 times, most recently
from
October 17, 2023 11:39
b03a6fe
to
1d4ac5e
Compare
andresmr
approved these changes
Oct 17, 2023
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 17, 2023 12:04
61f2927
to
4ec4a64
Compare
andresmr
requested changes
Oct 18, 2023
...em/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/component/InputFileResource.kt
Show resolved
Hide resolved
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
2 times, most recently
from
October 18, 2023 11:18
7bf9a09
to
c9883a7
Compare
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 18, 2023 11:28
00c27ff
to
e423d0a
Compare
andresmr
approved these changes
Oct 19, 2023
…bleState, code formated
…shell state added, test removed
…ar now is nested, hover disabled in text field, button type changed
… instead button, visual changes
DavidAparicioAlbaAsenjo
force-pushed
the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
from
October 19, 2023 11:20
3dcba49
to
aad5921
Compare
xavimolloy
deleted the
ANDROAPP-5575-mobile-ui-Create-InputFileResource-component
branch
October 26, 2023 05:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.