ANDROAPP-5592-mobile-ui-Create-List-Card-component #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmr
reviewed
Oct 3, 2023
designsystem/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/component/ListCard.kt
Outdated
Show resolved
Hide resolved
andresmr
reviewed
Oct 3, 2023
There was a problem hiding this comment.
I think that the image can be stored in the common module instead of designsystem to not package it with the library
|
|
||
| @OptIn(ExperimentalResourceApi::class) | ||
| @Composable | ||
| fun provideImage(resourceName: String): Painter = |
There was a problem hiding this comment.
I thin that this method can be set in the common module the library is not intended to store jpgs, right?
There was a problem hiding this comment.
It is just for the purpose of adding a painter to the Image and as a sample, it is in the same place as the providedhis2Icon method so I think it's ok, it's not intended to store jpgs and the user won't use it, as if they pass the painter with their own resource it'll work on both platforms
|
You have done a great job. Congratulations! 🥳 |
xavimolloy
force-pushed
the
ANDROAPP-5592-mobile-ui-Create-List-Card-component
branch
from
e533733 to
6206277
Compare
xavimolloy
force-pushed
the
ANDROAPP-5592-mobile-ui-Create-List-Card-component
branch
from
1d2de79 to
6a9f8ed
Compare
andresmr
approved these changes
Oct 4, 2023
mmmateos
approved these changes
Oct 4, 2023
xavimolloy
force-pushed
the
ANDROAPP-5592-mobile-ui-Create-List-Card-component
branch
from
6a9f8ed to
b3bb529
Compare
xavimolloy
force-pushed
the
ANDROAPP-5592-mobile-ui-Create-List-Card-component
branch
from
ae63c91 to
5aea3d4
Compare
xavimolloy
deleted the
ANDROAPP-5592-mobile-ui-Create-List-Card-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.