chore: [ANDROAPP-6676] Updates compose, kotlin, gradle, and dependencies versions #340
+302
−325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavimolloy
reviewed
Dec 12, 2024
| @@ -1,5 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <resources> | |||
| <string name="no_string_default">No string fo this key</string> | |||
There was a problem hiding this comment.
removed as its not needed
designsystem/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/component/AssistChip.kt
Show resolved
Hide resolved
| @@ -79,6 +86,29 @@ fun SupportingText( | |||
| LaunchedEffect(textLayoutResult) { | |||
| if (textLayoutResult == null) return@LaunchedEffect | |||
|
|
|||
| val link = LinkAnnotation.Clickable( | |||
There was a problem hiding this comment.
maybe this could be added to the ticket for things to be tested to verify that we haven't lost any functionality
xavimolloy
reviewed
Dec 12, 2024
ferdyrod
force-pushed
the
ANDROAPP-6676
branch
from
a8f69bb to
f25fd35
Compare
andresmr
approved these changes
Dec 18, 2024
Balcan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.