Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date format for InputAge component #298

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix date format for InputAge component #298

merged 3 commits into from
Sep 13, 2024

Conversation

siddh1004
Copy link
Collaborator

No description provided.

@siddh1004 siddh1004 changed the title Fix date time format for InputAge component Fix date format for InputAge component Sep 11, 2024
xavimolloy
xavimolloy requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@xavimolloy xavimolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do you think you could create or adapt some existing unit tests to verify that the component is formating date values correctly and will not crash if the value is in an unexpected format?

@andresmr andresmr merged commit 7b6f23c into develop Sep 13, 2024
2 checks passed
@andresmr andresmr deleted the ANDROAPP-6420-mobile-ui-InputAge-change-dateformat-output branch September 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavimolloy xavimolloy xavimolloy approved these changes

@andresmr andresmr andresmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddh1004 @andresmr @xavimolloy