Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROAPP-6097-Create-AssistChip-component #243

Closed
wants to merge 7 commits into from
Closed

ANDROAPP-6097-Create-AssistChip-component #243

wants to merge 7 commits into from

Conversation

DavidAparicioAlbaAsenjo
Copy link
Contributor

andresmr
andresmr requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@andresmr andresmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, create snapshot testing for this new component and unit if possible

@DavidAparicioAlbaAsenjo DavidAparicioAlbaAsenjo force-pushed the ANDROAPP-6097-Create-AssistChip-component branch from 1378bc2 to 82f0d68 Compare May 14, 2024 12:20
andresmr
andresmr requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@andresmr andresmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the base branch to develop

@DavidAparicioAlbaAsenjo DavidAparicioAlbaAsenjo deleted the ANDROAPP-6097-Create-AssistChip-component branch May 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmr andresmr andresmr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidAparicioAlbaAsenjo @andresmr