Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ANDROAPP-5550] scrolling over long text #102

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: [ANDROAPP-5550] scrolling over long text #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...tem/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/component/InputLongText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
package org.hisp.dhis.mobile.ui.designsystem.component

import androidx.compose.foundation.gestures.Orientation
import androidx.compose.foundation.gestures.scrollable
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
Expand Down Expand Up @@ -52,10 +49,7 @@ fun InputLongText(
onValueChanged = onValueChanged,
keyboardOptions = KeyboardOptions(imeAction = imeAction),
isSingleLine = false,
modifier = modifier.scrollable(
orientation = Orientation.Vertical,
state = rememberScrollState(),
).heightIn(Spacing.Spacing0, InternalSizeValues.Size300),
xavimolloy marked this conversation as resolved.
Show resolved Hide resolved
modifier = modifier.heightIn(Spacing.Spacing0, InternalSizeValues.Size300),
testTag = "LONG_TEXT",
onFocusChanged = onFocusChanged,
)
Expand Down