Fix merge errors

dhis2 · Aug 9, 2024 · a752b04 · a752b04
1 parent 82af024
commit a752b04
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 44 deletions.
diff --git a/common/src/commonMain/kotlin/org/hisp/dhis/common/screens/Groups.kt b/common/src/commonMain/kotlin/org/hisp/dhis/common/screens/Groups.kt
@@ -17,6 +17,6 @@ enum class Groups(val label: String) {
     METADATA_AVATAR("Metadata Avatar"),
     INDICATOR("Indicators"),
     PARAMETER_SELECTOR("Parameter selector"),
-    NO_GROUP_SELECTED("No group selected"),
     NAVIGATION_BAR("Navigation Bar"),
+    NO_GROUP_SELECTED("No group selected"),
 }
diff --git a/common/src/commonMain/kotlin/org/hisp/dhis/common/screens/others/NavigationBarScreen.kt b/common/src/commonMain/kotlin/org/hisp/dhis/common/screens/others/NavigationBarScreen.kt
@@ -1,8 +1,5 @@
 package org.hisp.dhis.common.screens.others
 
-import androidx.compose.foundation.background
-import androidx.compose.foundation.layout.Spacer
-import androidx.compose.foundation.layout.height
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.automirrored.filled.Assignment
 import androidx.compose.material.icons.automirrored.filled.List
@@ -24,13 +21,11 @@ import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
-import androidx.compose.ui.Modifier
+import org.hisp.dhis.common.screens.Groups
 import org.hisp.dhis.mobile.ui.designsystem.component.ColumnComponentContainer
-import org.hisp.dhis.mobile.ui.designsystem.component.SubTitle
+import org.hisp.dhis.mobile.ui.designsystem.component.ColumnScreenContainer
 import org.hisp.dhis.mobile.ui.designsystem.component.navigationBar.NavigationBar
 import org.hisp.dhis.mobile.ui.designsystem.component.navigationBar.NavigationBarItem
-import org.hisp.dhis.mobile.ui.designsystem.theme.Spacing
-import org.hisp.dhis.mobile.ui.designsystem.theme.SurfaceColor
 
 @Composable
 fun NavigationBarScreen() {
@@ -160,48 +155,46 @@ fun NavigationBarScreen() {
         ),
     )
 
-    ColumnComponentContainer(
-        title = "Navigation Bar",
-        modifier = Modifier
-            .background(SurfaceColor.Container),
+    ColumnScreenContainer(
+        title = Groups.NAVIGATION_BAR.label,
     ) {
-        SubTitle("Home")
-        var selectedHomeItemIndex by remember { mutableStateOf<Int?>(null) }
-        NavigationBar(
-            items = homeItems,
-            selectedItemIndex = selectedHomeItemIndex,
-        ) {
-            selectedHomeItemIndex = it
+        ColumnComponentContainer("Home") {
+            var selectedHomeItemIndex by remember { mutableStateOf<Int?>(null) }
+            NavigationBar(
+                items = homeItems,
+                selectedItemIndex = selectedHomeItemIndex,
+            ) {
+                selectedHomeItemIndex = it
+            }
         }
-
-        Spacer(modifier = Modifier.height(Spacing.Spacing24))
-        SubTitle("Program dashboard")
-        var selectedProgramItemIndex by remember { mutableStateOf<Int?>(null) }
-        NavigationBar(
-            items = programItems,
-            selectedItemIndex = selectedProgramItemIndex,
-        ) {
-            selectedProgramItemIndex = it
+        ColumnComponentContainer("Program dashboard") {
+            var selectedProgramItemIndex by remember { mutableStateOf<Int?>(null) }
+            NavigationBar(
+                items = programItems,
+                selectedItemIndex = selectedProgramItemIndex,
+            ) {
+                selectedProgramItemIndex = it
+            }
         }
 
-        Spacer(modifier = Modifier.height(Spacing.Spacing24))
-        SubTitle("Enrollment dashboard")
-        var selectedEnrollmentItemIndex by remember { mutableStateOf<Int?>(null) }
-        NavigationBar(
-            items = enrollmentItems,
-            selectedItemIndex = selectedEnrollmentItemIndex,
-        ) {
-            selectedEnrollmentItemIndex = it
+        ColumnComponentContainer("Enrollment dashboard") {
+            var selectedEnrollmentItemIndex by remember { mutableStateOf<Int?>(null) }
+            NavigationBar(
+                items = enrollmentItems,
+                selectedItemIndex = selectedEnrollmentItemIndex,
+            ) {
+                selectedEnrollmentItemIndex = it
+            }
         }
 
-        Spacer(modifier = Modifier.height(Spacing.Spacing24))
-        SubTitle("Form")
-        var selectedFormItemIndex by remember { mutableStateOf<Int?>(null) }
-        NavigationBar(
-            items = formItems,
-            selectedItemIndex = selectedFormItemIndex,
-        ) {
-            selectedFormItemIndex = it
+        ColumnComponentContainer("Form") {
+            var selectedFormItemIndex by remember { mutableStateOf<Int?>(null) }
+            NavigationBar(
+                items = formItems,
+                selectedItemIndex = selectedFormItemIndex,
+            ) {
+                selectedFormItemIndex = it
+            }
         }
     }
 }