Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ANDROAPP-6477] surround lateral menu navigation with async call #3885

Conversation

xavimolloy
Copy link
Contributor

This pull request includes several changes to improve the navigation and testing functionality in the MainActivity and related classes. The most important changes include adding a dispatcher provider to MainNavigator, refactoring the initialization of MainNavigator in MainActivity, and enhancing the MainRobot and MainTest classes for better test reliability.

Navigation Improvements:

Activity Initialization:

Testing Enhancements:

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@xavimolloy xavimolloy force-pushed the ANDROAPP-6477-Programs-are-hidden-after-navigating-to-settings-and-back branch from 96cb0a2 to 98a2064 Compare November 21, 2024 08:25
@xavimolloy xavimolloy force-pushed the ANDROAPP-6477-Programs-are-hidden-after-navigating-to-settings-and-back branch from 98a2064 to e7601f2 Compare November 22, 2024 12:25
@xavimolloy xavimolloy merged commit 2ec595a into develop Nov 22, 2024
3 checks passed
@xavimolloy xavimolloy deleted the ANDROAPP-6477-Programs-are-hidden-after-navigating-to-settings-and-back branch November 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants