Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation bar animation #3859

Conversation

siddh1004
Copy link
Contributor

@siddh1004 siddh1004 commented Nov 4, 2024

Description

Please include a summary of the change and include the related jira issue if it exists.

jira issue

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@siddh1004 siddh1004 force-pushed the ANDROAPP-6580-Incorrect-closing-navigation-bar-animation branch from 5336cf8 to 1f8ea75 Compare November 7, 2024 12:08
@siddh1004 siddh1004 force-pushed the ANDROAPP-6580-Incorrect-closing-navigation-bar-animation branch from 826fd53 to c71718f Compare November 8, 2024 06:41
Copy link

sonarqubecloud bot commented Nov 8, 2024

@Balcan Balcan merged commit 1a1d799 into dhis2:develop Nov 8, 2024
3 checks passed
Balcan added a commit that referenced this pull request Nov 8, 2024
andresmr pushed a commit that referenced this pull request Nov 8, 2024
* Fix navigation bar animation

* Fix lint error

* Fix animation jerk on search screen

* Fix FAB and navigation bar animation on program even detail screen

* Fix compose jerk

* Fix lint error

---------

Co-authored-by: Siddharth Agarwal <[email protected]>
(cherry picked from commit 1a1d799)
andresmr added a commit that referenced this pull request Nov 8, 2024
* Fix navigation bar animation

* Fix lint error

* Fix animation jerk on search screen

* Fix FAB and navigation bar animation on program even detail screen

* Fix compose jerk

* Fix lint error

---------

Co-authored-by: Siddharth Agarwal <[email protected]>
(cherry picked from commit 1a1d799)

Co-authored-by: Siddharth Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants