[ANDROAPP-6326] set default target SDK version #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andresmr <[email protected]>
andresmr
force-pushed
the
ANDROAPP-6326-Set-target-SDK-version-to-allow-old-sdk-warning-in-Androdi-14
branch
from
40d0b20 to
0aecd71
Compare
Signed-off-by: andresmr <[email protected]>
andresmr
force-pushed
the
ANDROAPP-6326-Set-target-SDK-version-to-allow-old-sdk-warning-in-Androdi-14
branch
from
e8468a6 to
f35d785
Compare
Signed-off-by: andresmr <[email protected]>
andresmr
force-pushed
the
ANDROAPP-6326-Set-target-SDK-version-to-allow-old-sdk-warning-in-Androdi-14
branch
from
f35d785 to
a55b830
Compare
|
xavimolloy
reviewed
Jul 18, 2024
| fun checkSyncWasSuccessfully() { | ||
| val expectedTitle = InstrumentationRegistry.getInstrumentation() | ||
| .targetContext.getString(R.string.sync_dialog_title_synced) | ||
| composeTestRule.waitUntilAtLeastOneExists(hasText(expectedTitle)) |
There was a problem hiding this comment.
this method I believe has a default time that throws an exception if not found, and is 1000 ms if not specified. I have seen tests fail due to the ocasional slow loading of the page other times this assertion was used, do you think it's a good idea to increase the time out to 2000 ms at least?
There was a problem hiding this comment.
yes, it has a default time 1000ms, so it's the time that the workers are setting sync successful, why don't we try the default implementation and if it fails we can think on increment it?
mmmateos
approved these changes
Jul 18, 2024
xavimolloy
approved these changes
Jul 18, 2024
andresmr
deleted the
ANDROAPP-6326-Set-target-SDK-version-to-allow-old-sdk-warning-in-Androdi-14
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.