[ANDROAPP-6039] Sort the search parameters #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddh1004
changed the title
andresmr
requested changes
Jul 10, 2024
app/src/main/java/org/dhis2/usescases/searchTrackEntity/SearchRepositoryImplKt.kt
Show resolved
Hide resolved
andresmr
approved these changes
Jul 15, 2024
added 4 commits
July 16, 2024 14:19
Sort the fields to have all the unique ones at the top and then sort the rest of the attributes as they are in the program configuration (in maintenance app) Expected order: - QR/barcode attributes (unique) - QR/barcode attributes (not unique) - Other Attributes (unique) - Configured order or default order (if not configured)
Add `SearchRepositoryImplKt` to test sorting of search parameter based on renderingType and isUnique properties
siddh1004
force-pushed
the
ANDROAPP-6039-Sort-QR-and-searchable-unique-TEAs-to-be-displayed-at-the-top-of-the-list-search-field
branch
from
eb0e176 to
b8e6e6b
Compare
|
xavimolloy
approved these changes
Jul 16, 2024
siddh1004
deleted the
ANDROAPP-6039-Sort-QR-and-searchable-unique-TEAs-to-be-displayed-at-the-top-of-the-list-search-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the fields to have all the unique ones at the top and then sort the rest of the attributes as they are in the program configuration (in maintenance app)
Expected order:
Description
Please include a summary of the change and include the related jira issue if it exists.
jira issue
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist