Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [ANDROAPP-5987] shouldSuccessfullyFilterByEventStatusOverdue #3656

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

mmmateos
Copy link
Contributor

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@mmmateos mmmateos force-pushed the ANDROAPP-5987 branch 2 times, most recently from 194bfcd to 55721ec Compare May 28, 2024 09:02
@mmmateos mmmateos marked this pull request as ready for review May 29, 2024 09:46
@@ -118,7 +118,7 @@ class EventRobot(val composeTestRule: ComposeTestRule) : BaseRobot() {
fun typeOnDateParameter(dateValue: String) {
composeTestRule.apply {
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performClick()
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performTextInput(dateValue)
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performTextReplacement(dateValue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice!
I found this solution:

node.performTextClearance()
node.performTextInput(dateValue)

But i think yours is more correct.

@mmmateos mmmateos force-pushed the ANDROAPP-5987 branch 2 times, most recently from cc64431 to a318875 Compare June 3, 2024 06:56
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mmmateos mmmateos merged commit 36837c9 into release/3.0.1 Jun 6, 2024
4 checks passed
@mmmateos mmmateos deleted the ANDROAPP-5987 branch June 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants