-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [ANDROAPP-5987] shouldSuccessfullyFilterByEventStatusOverdue #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmateos
force-pushed
the
ANDROAPP-5987
branch
2 times, most recently
from
May 28, 2024 09:02
194bfcd
to
55721ec
Compare
andresmr
approved these changes
May 31, 2024
@@ -118,7 +118,7 @@ class EventRobot(val composeTestRule: ComposeTestRule) : BaseRobot() { | |||
fun typeOnDateParameter(dateValue: String) { | |||
composeTestRule.apply { | |||
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performClick() | |||
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performTextInput(dateValue) | |||
onNodeWithTag("INPUT_DATE_TIME_TEXT_FIELD").performTextReplacement(dateValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice!
I found this solution:
node.performTextClearance()
node.performTextInput(dateValue)
But i think yours is more correct.
mmmateos
force-pushed
the
ANDROAPP-5987
branch
2 times, most recently
from
June 3, 2024 06:56
cc64431
to
a318875
Compare
xavimolloy
approved these changes
Jun 3, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist