-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [ANDROAPP-6609] Refactor program rules UI form's test to integration tests #3651
Conversation
|
||
testOptions { | ||
unitTests { | ||
isReturnDefaultValues = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because there was a error saying that the method "isEmpty()"in the Android's TextUtils class was not being mocked. Even though that method is not invoked anywhere in the code. The error happened when the method FormViewModel::processCalculatedItems() called the FormCountingIdlingResource.increment() method.
Adding this configuration fixed this problem
Quality Gate passedIssues Measures |
@@ -146,12 +145,13 @@ class FilterTest : BaseTest() { | |||
eventWithoutRegistrationRobot(composeTestRule) { | |||
clickOnEventAtPosition(0) | |||
} | |||
formRobot(composeTestRule) { | |||
// Commented because FormRobot class wah eliminated as FormTest was also eliminated | |||
/*formRobot(composeTestRule) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is no longer needed maybe we can remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, because this test is going to be looked at at some point. So it's better to leave it as it is so when someone does look into this, knows how the tests really is coded.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist