Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape #3647

Merged
merged 3 commits into from
May 22, 2024

Conversation

Balcan
Copy link
Collaborator

@Balcan Balcan commented May 22, 2024

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@andresmr andresmr changed the title [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape fix: [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape May 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andresmr andresmr merged commit e8e894c into main May 22, 2024
4 checks passed
xavimolloy pushed a commit that referenced this pull request May 23, 2024
)

* [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Check if grouped events option is visible

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Ignore flaky test

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>
CarlosMacaneta added a commit to Saudigitus/dhis2-emis-android that referenced this pull request Jun 26, 2024
* version name 3.0

Signed-off-by: Pablo <[email protected]>

* version name 3.0 (dhis2#3605)

Signed-off-by: Pablo <[email protected]>

* map is usable when card is first expanded to take full screen and then collapsed (dhis2#3601)

* fix: [ANDROAPP-6050] remove program name when scheduling event (dhis2#3596)

* [ANDROAPP-5701] Perform sync in local network (dhis2#3591)

* Perform sync in local network

Signed-off-by: Pablo <[email protected]>

* Perform sync in local network

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>
Co-authored-by: Pablo <[email protected]>

* update mobile-ui version (dhis2#3615)

* chore: [ANDROAPP-6139] Ignore flaky test (dhis2#3622)

* chore: [ANDROAPP-6139] ignoreflaky test

* fix: [ANDROAPP-6135] add ignore to shouldSuccessfullySyncSavedEvent

* chore: [ANDROAPP-6135] Update rule engine and expression parser to re… (dhis2#3623)

* chore: [ANDROAPP-6135] Update rule engine and expression parser to release version for 3.0

* chore: update rule-engine version 3.0.0

* fix: [ANDROAPP-6135] fix tests

---------

Co-authored-by: Victor Garcia <[email protected]>

* Update designSystem to release artifact 0.2 (dhis2#3627)

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6134] Update sdk release version to 1.10.0 (dhis2#3629)

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6161] Add server version 41 (dhis2#3630)

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Remove old form option (dhis2#3632)

* [ANDROAPP-6162] Remove COMPOSE_FORM option

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Ignore flaky test

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Ignore flaky test

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* Create deploy_release.yml

placeholder workflow

* Rename deploy_release.yml to deploy-release.yml

* Update deploy-release.yml

* feat: [ANDROAPP-6165] add continuous-delivery job to github (dhis2#3650)

* fix: [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape (dhis2#3647)

* [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Check if grouped events option is visible

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Ignore flaky test

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* ci: [ANDROAPP-6167] deploy release job

* ci: [ANDROAPP-6167] deploy release job

* ci: [ANDROAPP-6167] deploy release job

* update vCode

* build: 3.0 release (dhis2#3654)

* build: 3.0 release

* build: 3.0 release

* build: rename apk files

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>
Co-authored-by: Pablo <[email protected]>

* ci: Update version name to 3.0.0.1 and version code to 134

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6195] Add missing text resource keys (dhis2#3667)

* fix: [ANDROAPP-6195] Add missing text resource keys

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] remove duplicates and typos

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] remove duplicates

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] add missing transifex configuration

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6194] Search outside the program (dhis2#3664)

* fix: [ANDROAPP-6194] Send fetched list as parameter to avoid duplicated on search

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6194] Send fetched list as parameter to avoid duplicated on search

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6194] Add mockedWebServer response to mock get tracked entity instances

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6210] Manually instantiate resourceManager on BreakTheGlassBottomDialog (dhis2#3671)

Signed-off-by: andresmr <[email protected]>

* fix: missing translations (dhis2#3674)

* fix: missing translations

Signed-off-by: Pablo <[email protected]>

* fix: duplicated resources

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* chore: Update SDK to 1.10.0.1 (dhis2#3679)

* chore: Update SDK to 1.10.0.1-SNAPSHOT

Signed-off-by: andresmr <[email protected]>

* chore: Update SDK to 1.10.0.1

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* build: Update release notes

Signed-off-by: andresmr <[email protected]>

* fix: refactoring changes

* chore: klint checkstyle

* fix: setting semis verification on testing classes

---------

Signed-off-by: Pablo <[email protected]>
Signed-off-by: andresmr <[email protected]>
Co-authored-by: Pablo <[email protected]>
Co-authored-by: Ferdy Rodriguez <[email protected]>
Co-authored-by: Manu Muñoz <[email protected]>
Co-authored-by: Andrés Miguel Rubio <[email protected]>
Co-authored-by: Xavier Molloy <[email protected]>
Co-authored-by: Victor Garcia <[email protected]>
Co-authored-by: manu <[email protected]>
CarlosMacaneta added a commit to Saudigitus/dhis2-emis-android that referenced this pull request Jun 27, 2024
* version name 3.0

Signed-off-by: Pablo <[email protected]>

* version name 3.0 (dhis2#3605)

Signed-off-by: Pablo <[email protected]>

* map is usable when card is first expanded to take full screen and then collapsed (dhis2#3601)

* fix: [ANDROAPP-6050] remove program name when scheduling event (dhis2#3596)

* [ANDROAPP-5701] Perform sync in local network (dhis2#3591)

* Perform sync in local network

Signed-off-by: Pablo <[email protected]>

* Perform sync in local network

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>
Co-authored-by: Pablo <[email protected]>

* update mobile-ui version (dhis2#3615)

* chore: [ANDROAPP-6139] Ignore flaky test (dhis2#3622)

* chore: [ANDROAPP-6139] ignoreflaky test

* fix: [ANDROAPP-6135] add ignore to shouldSuccessfullySyncSavedEvent

* chore: [ANDROAPP-6135] Update rule engine and expression parser to re… (dhis2#3623)

* chore: [ANDROAPP-6135] Update rule engine and expression parser to release version for 3.0

* chore: update rule-engine version 3.0.0

* fix: [ANDROAPP-6135] fix tests

---------

Co-authored-by: Victor Garcia <[email protected]>

* Update designSystem to release artifact 0.2 (dhis2#3627)

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6134] Update sdk release version to 1.10.0 (dhis2#3629)

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6161] Add server version 41 (dhis2#3630)

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Remove old form option (dhis2#3632)

* [ANDROAPP-6162] Remove COMPOSE_FORM option

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Ignore flaky test

Signed-off-by: andresmr <[email protected]>

* [ANDROAPP-6162] Ignore flaky test

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* Create deploy_release.yml

placeholder workflow

* Rename deploy_release.yml to deploy-release.yml

* Update deploy-release.yml

* feat: [ANDROAPP-6165] add continuous-delivery job to github (dhis2#3650)

* fix: [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape (dhis2#3647)

* [ANDROAPP-6175] TeiDataFragment keeps reloading in landscape

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Check if grouped events option is visible

Signed-off-by: Pablo <[email protected]>

* [ANDROAPP-6175] Ignore flaky test

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* ci: [ANDROAPP-6167] deploy release job

* ci: [ANDROAPP-6167] deploy release job

* ci: [ANDROAPP-6167] deploy release job

* update vCode

* build: 3.0 release (dhis2#3654)

* build: 3.0 release

* build: 3.0 release

* build: rename apk files

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>
Co-authored-by: Pablo <[email protected]>

* ci: Update version name to 3.0.0.1 and version code to 134

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6195] Add missing text resource keys (dhis2#3667)

* fix: [ANDROAPP-6195] Add missing text resource keys

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] remove duplicates and typos

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] remove duplicates

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6195] add missing transifex configuration

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* fix: [ANDROAPP-6194] Search outside the program (dhis2#3664)

* fix: [ANDROAPP-6194] Send fetched list as parameter to avoid duplicated on search

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6194] Send fetched list as parameter to avoid duplicated on search

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6194] Add mockedWebServer response to mock get tracked entity instances

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* fix: [ANDROAPP-6210] Manually instantiate resourceManager on BreakTheGlassBottomDialog (dhis2#3671)

Signed-off-by: andresmr <[email protected]>

* fix: missing translations (dhis2#3674)

* fix: missing translations

Signed-off-by: Pablo <[email protected]>

* fix: duplicated resources

Signed-off-by: Pablo <[email protected]>

---------

Signed-off-by: Pablo <[email protected]>

* chore: Update SDK to 1.10.0.1 (dhis2#3679)

* chore: Update SDK to 1.10.0.1-SNAPSHOT

Signed-off-by: andresmr <[email protected]>

* chore: Update SDK to 1.10.0.1

Signed-off-by: andresmr <[email protected]>

---------

Signed-off-by: andresmr <[email protected]>

* build: Update release notes

Signed-off-by: andresmr <[email protected]>

* fix: refactoring changes

* chore: klint checkstyle

* feat: proposal to standardize TEI's cards

* chore: updating tei list card details

* fix: ignoring test

* chore(app-module): klint format

* chore(emis-module): klint format

---------

Signed-off-by: Pablo <[email protected]>
Signed-off-by: andresmr <[email protected]>
Co-authored-by: Pablo <[email protected]>
Co-authored-by: Ferdy Rodriguez <[email protected]>
Co-authored-by: Manu Muñoz <[email protected]>
Co-authored-by: Andrés Miguel Rubio <[email protected]>
Co-authored-by: Xavier Molloy <[email protected]>
Co-authored-by: Victor Garcia <[email protected]>
Co-authored-by: manu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants