Androapp 4826 display message when event has no sections or data elements config issue

form/src/main/java/org/dhis2/form/ui/Form.kt

@@ -6,13 +6,17 @@ import androidx.compose.foundation.ExperimentalFoundationApi
 import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
 import androidx.compose.foundation.interaction.MutableInteractionSource
+import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.itemsIndexed
 import androidx.compose.foundation.lazy.rememberLazyListState
+import androidx.compose.material.Icon
+import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.outlined.ErrorOutline
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.MutableState
@@ -29,13 +33,17 @@ import androidx.compose.ui.unit.dp
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
 import org.dhis2.commons.resources.ResourceManager
+import org.dhis2.form.R
 import org.dhis2.form.model.FieldUiModel
 import org.dhis2.form.model.FormSection
 import org.dhis2.form.ui.event.RecyclerViewUiEvents
 import org.dhis2.form.ui.intent.FormIntent
 import org.dhis2.form.ui.provider.inputfield.FieldProvider
+import org.hisp.dhis.mobile.ui.designsystem.component.InfoBar
+import org.hisp.dhis.mobile.ui.designsystem.component.InfoBarData
 import org.hisp.dhis.mobile.ui.designsystem.component.Section
 import org.hisp.dhis.mobile.ui.designsystem.component.SectionState
+import org.hisp.dhis.mobile.ui.designsystem.theme.SurfaceColor
 
 @OptIn(ExperimentalFoundationApi::class)
 @Composable
@@ -59,20 +67,20 @@ fun Form(
             }
         }
     }
-    val focusNext = remember { mutableStateOf(false) }
-    LazyColumn(
-        modifier = Modifier
-            .fillMaxSize()
-            .background(Color.White)
-            .clickable(
-                interactionSource = MutableInteractionSource(),
-                indication = null,
-                onClick = { focusManager.clearFocus() },
-            ),
-        contentPadding = PaddingValues(horizontal = 16.dp, vertical = 16.dp),
-        state = scrollState,
-    ) {
-        if (sections.isNotEmpty()) {
+    if (sections.isNotEmpty()) {
+        val focusNext = remember { mutableStateOf(false) }
+        LazyColumn(
+            modifier = Modifier
+                .fillMaxSize()
+                .background(Color.White)
+                .clickable(
+                    interactionSource = MutableInteractionSource(),
+                    indication = null,
+                    onClick = { focusManager.clearFocus() },
+                ),
+            contentPadding = PaddingValues(horizontal = 16.dp, vertical = 16.dp),
+            state = scrollState,
+        ) {
             this.itemsIndexed(
                 items = sections,
                 key = { _, fieldUiModel -> fieldUiModel.uid },
@@ -100,7 +108,7 @@ fun Form(
                 Section(
                     title = section.title,
                     isLastSection = getNextSection(section, sections) == null,
-                    description = section.description,
+                    description = if (sections.size >= 2 && section.fields.isNotEmpty()) section.description else null,
                     completedFields = section.completedFields(),
                     totalFields = section.fields.size,
                     state = section.state,
@@ -111,29 +119,55 @@ fun Form(
                         intentHandler.invoke(FormIntent.OnSection(section.uid))
                     },
                     content = {
-                        section.fields.forEachIndexed { index, fieldUiModel ->
-                            fieldUiModel.setCallback(callback)
-                            FieldProvider(
-                                modifier = Modifier.animateItemPlacement(
-                                    animationSpec = tween(
-                                        durationMillis = 500,
-                                        easing = LinearOutSlowInEasing,
+                        if (sections.size >= 2 && section.fields.isNotEmpty()) {
+                            section.fields.forEachIndexed { index, fieldUiModel ->
+                                fieldUiModel.setCallback(callback)
+                                FieldProvider(
+                                    modifier = Modifier.animateItemPlacement(
+                                        animationSpec = tween(
+                                            durationMillis = 500,
+                                            easing = LinearOutSlowInEasing,
+                                        ),
                                     ),
-                                ),
-                                fieldUiModel = fieldUiModel,
-                                uiEventHandler = uiEventHandler,
-                                intentHandler = intentHandler,
-                                resources = resources,
-                                focusManager = focusManager,
-                                onNextClicked = {
-                                    if (index == section.fields.size - 1) {
-                                        onNextSection()
-                                        focusNext.value = true
-                                    } else {
-                                        focusManager.moveFocus(FocusDirection.Down)
-                                    }
-                                },
-                            )
+                                    fieldUiModel = fieldUiModel,
+                                    uiEventHandler = uiEventHandler,
+                                    intentHandler = intentHandler,
+                                    resources = resources,
+                                    focusManager = focusManager,
+                                    onNextClicked = {
+                                        if (index == section.fields.size - 1) {
+                                            onNextSection()
+                                            focusNext.value = true
+                                        } else {
+                                            focusManager.moveFocus(FocusDirection.Down)
+                                        }
+                                    },
+                                )
+                            }
+                        } else {
+                            Column(
+                                modifier = Modifier
+                                    .height(120.dp),
+                            ) {
+                                InfoBar(
+                                    infoBarData = InfoBarData(
+                                        text = resources.getString(R.string.form_without_fields),
+                                        icon = {
+                                            Icon(
+                                                imageVector = Icons.Outlined.ErrorOutline,
+                                                contentDescription = "no fields",
+                                                tint = SurfaceColor.Warning,
+                                            )
+                                        },
+                                        color = SurfaceColor.Warning,
+                                        backgroundColor = SurfaceColor.WarningContainer,
+                                        actionText = null,
+                                        onClick = null,
+                                    ),
+                                    modifier = Modifier
+                                        .background(SurfaceColor.WarningContainer),
+                                )
+                            }
                         }
                     },
                 )
@@ -142,6 +176,30 @@ fun Form(
                 Spacer(modifier = Modifier.height(120.dp))
             }
         }
+    } else {
+        Column(
+            modifier = Modifier
+                .height(120.dp),
+        ) {
+            InfoBar(
+                infoBarData = InfoBarData(
+                    text = resources.getString(R.string.form_without_fields),
+                    icon = {
+                        Icon(
+                            imageVector = Icons.Outlined.ErrorOutline,
+                            contentDescription = "no fields",
+                            tint = SurfaceColor.Warning,
+                        )
+                    },
+                    color = SurfaceColor.Warning,
+                    backgroundColor = SurfaceColor.WarningContainer,
+                    actionText = null,
+                    onClick = null,
+                ),
+                modifier = Modifier
+                    .background(SurfaceColor.WarningContainer),
+            )
+        }
     }
 }
 

form/src/main/java/org/dhis2/form/ui/mapper/FormSectionMapper.kt

@@ -29,16 +29,6 @@ class FormSectionMapper {
                     )
                 }
             }
-        } else {
-            sections.add(
-                FormSection(
-                    uid = "DUMMY",
-                    title = "TITLE",
-                    description = null,
-                    state = SectionState.NO_HEADER,
-                    fields = items.filterIsInstance<FieldUiModelImpl>(),
-                ),
-            )
         }
 
         return sections

ui-components/src/main/res/values/strings.xml

@@ -14,6 +14,7 @@
     <string name="action_cancel">Cancel</string>
     <string name="hint_search">Search</string>
     <string name="action_clear_all">Clear all</string>
+    <string name="form_without_fields">This form has no fields configured</string>
     <plurals name="error_count">
         <item quantity="one">%s error</item>
         <item quantity="other">%s errors</item>