feat: Update to DHIS2 Android SDK 1.9.1-20231215.100321-10 #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdyrod
approved these changes
Dec 15, 2023
ferdyrod
force-pushed
the
androsdk-1682
branch
2 times, most recently
from
771dc37 to
43ce657
Compare
andresmr
force-pushed
the
androsdk-1682
branch
from
43ce657 to
c085a33
Compare
andresmr
approved these changes
Dec 18, 2023
andresmr
force-pushed
the
androsdk-1682
branch
from
c085a33 to
a953d57
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt to changes in the SDK due to the refactor from Java to Kotlin. They are mainly caused by Kotlin-Java interoperability shortcuts: a java method called "getName()" is suggested as just ".name" by Android Studio in Kotlin code. If the method keeps the signature "getName()" when refactored to Kotlin, the shortcut does not work anymore and the method must be accessed by "getName()" in Kotlin as well.
Solution description
Covered unit test cases
Where did you test this issue?
Which Android versions did you test this issue?
Checklist