Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump analytics with fix for DHIS2-16904 #3124

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jun 24, 2024

Part of the fix for DHIS2-16904

Requires dhis2/analytics#1685


Key features

  1. bump analytics dependency

Description

The actual fix is in @dhis2/multi-calendar-dates which is a dependency of analytics and it's used in the PeriodSelector component the analytics apps use.
See also the PR in analytics.


TODO

  • Manual testing

Screenshots

Translations don't work for week/bi-week:
Screenshot 2024-06-24 at 16 03 35

After:
Screenshot 2024-06-25 at 09 18 40

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 25, 2024

@edoardo edoardo marked this pull request as ready for review June 25, 2024 07:25
@dhis2-bot dhis2-bot temporarily deployed to netlify June 25, 2024 07:27 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 25, 2024 09:52 Inactive
@HendrikThePendric HendrikThePendric enabled auto-merge (squash) June 25, 2024 10:02
@HendrikThePendric HendrikThePendric merged commit 4996f7a into master Jun 25, 2024
27 checks passed
@HendrikThePendric HendrikThePendric deleted the fix/period-translations-DHIS2-16904 branch June 25, 2024 10:25
dhis2-bot added a commit that referenced this pull request Jun 25, 2024
## [100.5.8](v100.5.7...v100.5.8) (2024-06-25)

### Bug Fixes

* bump analytics with fix for DHIS2-16904 ([#3124](#3124)) ([4996f7a](4996f7a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants