fix: avoid flashing when ou levels are used (DHIS2-17136) #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3032--dhis2-data-visualizer.netlify.app |
Passing run #2812 ↗︎
Details:
Review all test suite changes for PR #3032 ↗︎ |
|||||||||||||||
edoardo
force-pushed
the
fix/plugin-flashing-resize
branch
from
8b058da to
27916b2
Compare
edoardo
force-pushed
the
fix/plugin-flashing-resize
branch
from
27916b2 to
02b87bf
Compare
edoardo
changed the title
jenniferarnesen
approved these changes
Apr 26, 2024
Merged
dhis2-bot
added a commit
that referenced
this pull request
May 13, 2024
## [100.5.4](v100.5.3...v100.5.4) (2024-05-13) ### Bug Fixes * avoid flashing when ou levels are used (DHIS2-17136) ([#3032](#3032)) ([b1b6148](b1b6148)) * fix a crash when row totals is enabled (DHIS2-17297) ([#3042](#3042)) ([4004455](4004455)) * **translations:** sync translations from transifex (dev) ([f1a14b8](f1a14b8))
|
🎉 This PR is included in version 100.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kabaros
pushed a commit
that referenced
this pull request
May 30, 2024
## [100.5.4](v100.5.3...v100.5.4) (2024-05-13) ### Bug Fixes * avoid flashing when ou levels are used (DHIS2-17136) ([#3032](#3032)) ([b1b6148](b1b6148)) * fix a crash when row totals is enabled (DHIS2-17297) ([#3042](#3042)) ([4004455](4004455)) * **translations:** sync translations from transifex (dev) ([f1a14b8](f1a14b8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fixes for DHIS2-17136
Key features
Description
This only happened when ou levels were selected for the ou dimension.
The fix avoids that the visualization object passed to the ChartPlugin is a different one every time.