fix: accept displayProperty of both with and without display prefix [v39] #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3031--dhis2-data-visualizer.netlify.app |
|
not needed |
jenniferarnesen
deleted the
fix/backwards-compatible-shortname-for-analytics-v39
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for https://dhis2.atlassian.net/browse/DHIS2-12499
The LL and DV plugin treat the
displayPropertyprop differently. LL accepts the value as is, while DV expects it to have the 'display' prefix and then converts it. The result is that displayProperty does not get set for DV for the analytics request.Before:
After: