Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: about AO showed wrong datetime, newlines in interpretations and replies not preserved [v39] #3003

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Mar 20, 2024

Fixes https://dhis2.atlassian.net/browse/DHIS2-15825 and https://dhis2.atlassian.net/browse/DHIS2-16365

Requires dhis2/analytics#1642

This PR supersedes #2892

Key features

  1. Show correct date and time in About AO Unit in interpretations panel
  2. Preserve newlines in interpretations and replies
    (yarn-deduplicate was run to make sure that plugin also uses the 24.10.3 version of analytics.)

Other changes since analytics was last updated:

  1. feat: single value background color change based upon legend (DHIS2-13702)
  2. fix: sv size when downloading is a small square (DHIS2-15178)
  3. fix: avoid undefined in totals DHIS2-14511

Screenshot shows chart was just created. Timestamp is "a few seconds ago", rather than "1 hour ago" which is the bug you would see in GMT+1
image
image

@dhis2-bot
Copy link
Contributor

Copy link

cypress bot commented Mar 20, 2024

Passing run #2730 ↗︎

0 610 0 0 Flakiness 0

Details:

Merge a698fda into fcbc341...
Project: Data Visualizer App Commit: c0fd498f3a ℹ️
Status: Passed Duration: 07:40 💡
Started: Mar 20, 2024 5:15 PM Ended: Mar 20, 2024 5:23 PM

Review all test suite changes for PR #3003 ↗︎

@jenniferarnesen jenniferarnesen requested a review from edoardo March 21, 2024 08:26
@martinkrulltott
Copy link
Contributor

It's been a long time since I looked at it last, but the two tickets from me (DHIS2-13702, DHIS2-15178) seems to be working as they should after some brief testing.

@jenniferarnesen jenniferarnesen changed the title fix: about AO showed wrong datetime, newlines in interpretations and replies not preserved fix: about AO showed wrong datetime, newlines in interpretations and replies not preserved [v39] Mar 21, 2024
@jenniferarnesen jenniferarnesen merged commit 9b13adc into 39.x Mar 22, 2024
22 checks passed
@jenniferarnesen jenniferarnesen deleted the fix/interp-dt-and-para-39x-latest branch March 22, 2024 10:12
dhis2-bot added a commit that referenced this pull request Mar 22, 2024
## [39.2.22](v39.2.21...v39.2.22) (2024-03-22)

### Bug Fixes

* about AO showed wrong datetime, newlines in interpretations and replies [v39] ([#3003](#3003)) ([9b13adc](9b13adc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 39.2.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants